WIP Cred vending isolation #2278
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snazy
force-pushed
the
cred-vend-creds-cache-wip
branch
3 times, most recently
from
ce7c3ad to
415a31c
Compare
Setting an S3 internal endpoint doesn't work, because the property's not carried over from the OpenAPI model type into `AwsStorageConfigInfo`.
The `persistStorageIntegrationIfNeeded` function does nothing in any implementation, therefore the corresponding load-function cannot yield anything ever. This change removes both functions. That allows removing the `createStorageIntegration` function as well and let its only call site `getSubscopedCredsForEntity` be implemented once and directly call the storage integration provider. Being able to access object storage without access to entities is a requirement for all currently active tasks proposals. This is one step towards that goal.
snazy
force-pushed
the
cred-vend-creds-cache-wip
branch
from
415a31c to
7f09cc3
Compare
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
github-project-automation
bot
moved this from PRs In Progress
to Done
in Basic Kanban Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #2277 - WIP